-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node: Governor token list update #4253
base: main
Are you sure you want to change the base?
node: Governor token list update #4253
Conversation
djb15
commented
Feb 1, 2025
•
edited
Loading
edited
StablecoinsThe chain 16 stablecoin is one that we already know isn't properly captured by CoinGecko but I checked on the prices of the other tokens marked as stablecoins. Synthetic USDThis token appears to be archived according to CoinGecko. https://www.coingecko.com/en/coins/synthetic-usd
Coin98I can't find any reference to Coin98 being a stablecoin so I think the 'stablecoin depeg' notice here is a false positive. We should probably add it to the allow-list in the script. https://www.coingecko.com/en/coins/coin98-dollar
|
To make our lives easier, it would be nice if this script also generated a URL to the CoinGecko page based on the CoinGecko ID, if it exists. |
I think CUSD is supposed to be a stablecoin: https://docs.coin98.com/audits/coin98-dollar. Also if you look back far enough it was previously pegged to $1. I'd rather keep it around for now and we can reassess if it becomes a regular occurrence?
Great suggestion! I can't believe I never realised that the CoinGecko id is the URL slug 🤦♂️ |
f66837f
to
6b6519d
Compare
@@ -274,7 +276,7 @@ axios | |||
|
|||
// We add in the "=" character to ensure an undefined symbol | |||
// does not mess up the removed tokens logic | |||
newTokenKeys[chain + "-" + wormholeAddr] = "=" + data.Symbol; | |||
newTokenKeys[chain + "-" + wormholeAddr] = ["=" + data.Symbol, data.CoinGeckoId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If data.Symbol
is undefined, is this line going to hide that? It might make it look like data.CoinGeckId
is the symbol.
It might be worth replacing data.Symbol
with a string like UNDEFINED
manually if it doesn't exist rather than use an empty string (which I assume is what happens now)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be misunderstanding but I don't think this is true? The symbol logic is identical to before, I've just changed the mapping from string=>string
to string=>[string, string]
. And I index into the array with the changes below
Left a comment about the script modifications. Keeping CUSD as-is sounds good to me |