Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw error when rule with the same name is found multiple times #178

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

pkhabazi
Copy link
Contributor

@pkhabazi pkhabazi commented May 9, 2021

Summary of the Pull Request

This pr adds an extra validation step to the import-azsentinelalertrule function to throw an error when the is an alert rule with the same name found multiple tipes.

References

...

PR Checklist

By submitting this pull request, I confirm the following:

please fill any appropriate checkboxes, e.g: [X]

  • Closes #xxx
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • It is compatible with the MIT License
  • I have squashed any insignificant commits. (git rebase)

Detailed Description of the Pull Request / Additional comments

A detailed description, screenshots (if necessary), as well as links to any relevant issues

Validation Steps Performed

A detailed description of thew validation steps

How does this PR accomplish the above

A detailed description (such as a changelog) and screenshots (if necessary) of the implemented fix

What documentation changes (if any) are needed to support this PR

A detailed list of any necessary changes


  • You must follow the template instructions. Failure to do so will result in your pull request being closed.

@pkhabazi pkhabazi self-assigned this May 9, 2021
@pkhabazi pkhabazi changed the base branch from master to development August 2, 2021 09:54
@pkhabazi pkhabazi merged commit da54820 into development Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant