-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Symfony 6/Laravel 9 #128
Conversation
7835e6e
to
dbf0c8b
Compare
Hi, When running
|
When running
Since Laravel8, we have to extends resolvePath() method in
|
Hi @Broutard. Thank you for testing out this PR! I've tried to fix your first comment. If I'm understand your second comment correctly, this is also a bug in the current release of this bundle? If so, could you maybe sent a new PR with a fix? (and if possible a test case for the fix) Thank you! :) |
e791b84
to
58c7040
Compare
@wouterj for the 2nd, the bug should appear also with Laravel8 (not tested) |
So we will have a new release version of this bundle after Larevel 9 is released? |
Yes, I'm trying to keep up with Laravel releases. Depending on the available time, a new version will be released in the days/weeks after the Laravel release. |
which news guys ? i have same error |
Here is my fix code in Service namespace App\Service; use WouterJ\EloquentBundle\Migrations\Migrator as BaseMigrator; class CustomMigrator extends BaseMigrator
} in eloquent.yaml |
Laravel 9 is the first version that comes with support for Symfony 6 and is expected to be released in January.