Remove data-collector when no twig or profiler present #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wouterj I essentially use this patch from a month now without any issues. Can we get that merged? |
wouterj
force-pushed
the
remove-data-collector
branch
from
c9c3da6 to
6d2cfd0
Compare
|
Thank you @brzuchal. I've added a commit to your PR to add a test and change the if condition, as DI extensions get a clean container and not the real container - so the This new condition should be safe now, if I read the issue correctly. Can you give this a spin? If it works, I'll release 2.3.1 with this fix :) |
|
Thanks @wouterj I can test it next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel version: 8.x
Symfony version: 5.0
Closes #130