Many changes #1
Merged
Many changes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
barncastle
commented
May 25, 2019
barncastle
commented
- Added a solution file and some new projects
- Unit Test (can remove was just for testing... funnily enough)
- DBFileReaderLib
- Added DBFileReaderLib so the lib supports reading
- Supports all DB types and now DBCache.bin
- purposely segregated as per @Marlamin's request
- Fixes
- Added a field accessor for DBCDRows
revert project frameworks to netstandard2.0
|
Minor note, neither DBCD or DBFileReaderLib can be compiled as Release due to missing I also just pushed a new version of DBDefsLib that doesn't try to open files for writing when reading. |
|
Crashes when parsing soundkitname.db2 from 8.2.0.30669 and possibly more builds. Issue seems to be centered around stringTable reading. Crashes on line 59/60 of WDC3Reader.cs with |
|
@Marlamin these should be fixed with the above two commits |
change indexer to return a single record instead of an IEnumerable change DBCDStorage to concrete it's records on load for better performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.