Calling DBCDStorage.Save() twice causes an ArgumentException #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the Storage is not cleared after a Save() as it is in the constructor for a DBCDStorage, calling this method twice will result in an attempt to add the same keys to the underlying dictionary, which causes an ArgumentException.
This PR fixes the ArgumentException by clearing the Storage after the Save() operation similar to how it is cleared in the constructor after loading.
See also the added test for the minimal reproducible scenario this PR fixes, current test will fail with an ArgumentException in DBCD 2.0.1.