Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI][ENHANCEMENT] Highlight changed reforges after applying "Suggest Reforges" #967

Closed
Lawdie opened this issue Aug 22, 2024 · 4 comments
Closed
Labels
enhancement New feature or request

Comments

@Lawdie
Copy link

Lawdie commented Aug 22, 2024

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
When you press "Suggest Reforges" but already have gear with reforges, highlight items that have their reforges changed in a different colour text or with a border.

This makes it easier to update reforges after a gear slot upgrade instead of having to check every slot again.

Describe alternatives you've considered
N/A

Additional context
Scuffed example
image

@1337LutZ
Copy link
Contributor

@Lawdie We already have discussed this topic.
Our idea is; Add a link in the "Reforging done" Toast (bottom right) that will open a Modal/Popup showing what the changes per slot were.

@Lawdie
Copy link
Author

Lawdie commented Aug 23, 2024

@Lawdie We already have discussed this topic. Our idea is; Add a link in the "Reforging done" Toast (bottom right) that will open a Modal/Popup showing what the changes per slot were.

Sounds fine with me, just anything to make it more obvious what got changed!

@1337LutZ 1337LutZ added the enhancement New feature or request label Aug 23, 2024
@hillerstorm
Copy link
Contributor

@Lawdie We already have discussed this topic. Our idea is; Add a link in the "Reforging done" Toast (bottom right) that will open a Modal/Popup showing what the changes per slot were.

Sounds fine with me, just anything to make it more obvious what got changed!

In the meantime, ReforgeLite actually has an import feature that accepts the json from wowsims Export -> JSON. This way you can reforge in the sim -> export from the sim -> open ReforgeLite -> press Import WoWSims and paste the JSON -> press Show and go to reforge npc 😃

@1337LutZ 1337LutZ changed the title Highlight changed reforges after applying "Suggest Reforges" [UI][ENHANCEMENT] Highlight changed reforges after applying "Suggest Reforges" Aug 28, 2024
@hillerstorm
Copy link
Contributor

Fixed in #1061

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants