Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Extend suggest reforge toast #1061

Merged
merged 7 commits into from
Sep 27, 2024
Merged

[UI] Extend suggest reforge toast #1061

merged 7 commits into from
Sep 27, 2024

Conversation

1337LutZ
Copy link
Contributor

@1337LutZ 1337LutZ commented Sep 26, 2024 •
edited
Loading

No changes
image

Changes
image

image

@1337LutZ 1337LutZ changed the title Feature/extend reforger toast [UI] Extend suggest reforge toast Sep 26, 2024
NerdEgghead
NerdEgghead reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@NerdEgghead NerdEgghead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but left some comments on how to make the code object-oriented so it's cleaner and more readable.

ui/core/components/suggest_reforges_action.tsx Outdated Show resolved Hide resolved
ui/core/components/suggest_reforges_action.tsx Outdated Show resolved Hide resolved
ui/core/components/suggest_reforges_action.tsx Outdated Show resolved Hide resolved
NerdEgghead
NerdEgghead reviewed Sep 27, 2024
View reviewed changes
ui/core/components/suggest_reforges_action.tsx Outdated Show resolved Hide resolved
ui/core/components/suggest_reforges_action.tsx Show resolved Hide resolved
ui/core/player.ts Outdated Show resolved Hide resolved
@1337LutZ 1337LutZ merged commit dd04030 into master Sep 27, 2024
2 checks passed
@1337LutZ 1337LutZ deleted the feature/extend-reforger-toast branch September 27, 2024 11:14
@hillerstorm hillerstorm mentioned this pull request Oct 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hillerstorm hillerstorm Awaiting requested review from hillerstorm

@NerdEgghead NerdEgghead Awaiting requested review from NerdEgghead

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1337LutZ @NerdEgghead