Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Warrior] remove noOnCastComplete flag from inner rage to enable t13-2p aura proc #1003

Merged
merged 1 commit into from
Sep 12, 2024
Merged

[Warrior] remove noOnCastComplete flag from inner rage to enable t13-2p aura proc #1003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sim/warrior/arms/TestArms.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,8 @@ dps_results: {
dps_results: {
key: "TestArms-AllItems-ColossalDragonplateBattlegear"
value: {
dps: 31124.41164
tps: 21228.11886
dps: 31370.06649
tps: 21139.14873
}
}
dps_results: {
Expand Down
4 changes: 2 additions & 2 deletions sim/warrior/fury/TestFury.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,8 +277,8 @@ dps_results: {
dps_results: {
key: "TestFury-AllItems-ColossalDragonplateBattlegear"
value: {
dps: 27897.94193
tps: 22905.02518
dps: 28775.1206
tps: 23697.50447
}
}
dps_results: {
Expand Down
2 changes: 1 addition & 1 deletion sim/warrior/inner_rage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func (warrior *Warrior) RegisterInnerRage() {

ir := warrior.RegisterSpell(core.SpellConfig{
ActionID: actionID,
Flags: core.SpellFlagHelpful | core.SpellFlagNoOnCastComplete | core.SpellFlagMCD | core.SpellFlagAPL,
Flags: core.SpellFlagHelpful | core.SpellFlagMCD | core.SpellFlagAPL,
SpellSchool: core.SpellSchoolPhysical,
ClassSpellMask: SpellMaskInnerRage,

Expand Down
Loading