Generalized Feral bleed snapshotting algorithm #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 11, 2024 14:28
clips are actually free, and changed clip time from just before buff expiration to the start of that tick instead for more leeway. On branch feral Changes to be committed: modified: sim/druid/feral/TestFeral.results modified: sim/druid/feral/rotation.go
final tick always gets clipped to a lower power value in practice. On branch feral Changes to be committed: modified: sim/druid/feral/TestFeral.results modified: sim/druid/feral/rotation.go
buffed tick count (which was enforcing the same outcome) in prep for generalized algorithm. On branch feral Changes to be committed: modified: sim/druid/feral/rotation.go
that increases Rip bleed power. On branch feral Changes to be committed: modified: sim/core/aura_helpers.go modified: sim/core/unit.go modified: sim/druid/druid.go modified: sim/druid/feral/TestFeral.results modified: sim/druid/feral/feral.go modified: sim/druid/feral/rotation.go modified: sim/druid/rip.go
On branch feral Changes to be committed: modified: sim/druid/feral/TestFeral.results modified: sim/druid/feral/feral.go modified: sim/druid/feral/rotation.go modified: sim/druid/rake.go
added 3 commits
September 12, 2024 19:21
On branch feral Changes to be committed: modified: sim/druid/feral/TestFeral.results modified: sim/druid/feral/feral_test.go
On branch feral Changes to be committed: modified: sim/druid/feral/feral_test.go
On branch feral Changes to be committed: modified: sim/druid/feral/feral_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalizes the existing analytical logic used for clipping Rip situationally to snapshot Tiger's Fury (when doing so is a net DPE gain), and applies it to arbitrary temporary bleed power buffs implemented via TemporaryStatsAura helpers. Also applies the same logic to Rake snapshotting.
Net DPS impacts of this PR under default settings:
P1 gear, mono-cat talents = +142 DPS
P1 gear, hybrid talents = +85 DPS
P3 gear, mono-cat talents = +52 DPS
P3 gear, hybrid talents = +127 DPS