[Item] Add all phase 4 trinkets including item notices

[hillerstorm]

Also changed Spidersilk Spindle to reduce incoming damage (like Savage Defense) instead of healing to be able to see its effects on incoming damage.
All proc masks and coefficients should be correct to how it is in the dbc and reading up on patch changes.

Added item notices for all of the procc trinkets, including the healing ones not being implemented.
Also added "not ingame" notices for the 384/410 variants of the Valor Trinkets which, just like some Firelands stuff, were never actually in game.

[1337LutZ]

@hillerstorm I asked @RobFalfa to take a look at this and compare it with his implementations

[zoristaken]

About adding notices to items that were never in the game, I think It should be more correct, the moment we have confirmation that those versions won't exist in classic, to blacklist them instead of having them available as a choice. Seems fine for now since we don't know yet if they will reuse them.

[hillerstorm]

About adding notices to items that were never in the game, I think It should be more correct, the moment we have confirmation that those versions won't exist in classic, to blacklist them instead of having them available as a choice. Seems fine for now since we don't know yet if they will reuse them.

Yea that's my thinking as well. As soon as we get confirmation of blizzard not adding the upgraded firelands items we should blacklist them etc.
The text could perhaps be even more detailed, explaining a bit more.

[1337LutZ]

About adding notices to items that were never in the game, I think It should be more correct, the moment we have confirmation that those versions won't exist in classic, to blacklist them instead of having them available as a choice. Seems fine for now since we don't know yet if they will reuse them.

Yea that's my thinking as well. As soon as we get confirmation of blizzard not adding the upgraded firelands items we should blacklist them etc. The text could perhaps be even more detailed, explaining a bit more.

Yea I agree.

[hillerstorm]

Updated the item-doesnt-exist-notice a bit:

[1337LutZ]

Updated the item-doesnt-exist-notice a bit:

Nice!

[hillerstorm]

I added a TODO comment on Vial of Shadows regarding the AP modifier with some links for reference later.

Would you feel comfortable with merging this @NerdEgghead seeing as I touched Savage Defense? :) that change didn't result in any test diffs and from my own testing it looked great.