[FIX] Bulk sim issues #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1337LutZ
commented
Jun 18, 2024
| @@ -495,23 +495,8 @@ func isValidEquipment(equipment *proto.EquipmentSpec) bool { | |||
| return false | |||
| } | |||
|
|
|||
| // Validate trinkets/rings for duplicate IDs | |||
| if equipment.Items[proto.ItemSlot_ItemSlotFinger1].Id == equipment.Items[proto.ItemSlot_ItemSlotFinger2].Id && equipment.Items[proto.ItemSlot_ItemSlotFinger1].Id != 0 { | |||
There was a problem hiding this comment.
There's no need to do this, as the FE UI doesn't allow for unique-equipped duplicates, and this would return as not valid if there's items that are not unique-equipped.
1337LutZ
commented
Jun 18, 2024
| return false | ||
| } | ||
|
|
||
| // Validate rings/trinkets for heroic/non-heroic (matching name) |
There was a problem hiding this comment.
Same here, no need to check all of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
randomSuffixesandreforgeStatsto database