Merge pull request #1093 from ncberman/hunter_chimeraSerpentFix

(Minor Fix) Chimera-Serpent didn't have appropriate CastType causing extra misses
wowsims · Sep 25, 2024 · f8f06a1 · f8f06a1
2 parents e1a3cfd + ea64d29
commit f8f06a1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/sim/hunter/TestMM.results b/sim/hunter/TestMM.results
@@ -246,15 +246,15 @@ dps_results: {
 dps_results: {
  key: "TestMM-Phase2-Lvl40-Settings-Dwarf-p2_ranged_mm-Basic-p2_ranged_mm-FullBuffs-P2-Consumes-LongMultiTarget"
  value: {
- dps: 635.42505
- tps: 618.93652
+ dps: 635.84597
+ tps: 619.27522
  }
 }
 dps_results: {
  key: "TestMM-Phase2-Lvl40-Settings-Dwarf-p2_ranged_mm-Basic-p2_ranged_mm-FullBuffs-P2-Consumes-LongSingleTarget"
  value: {
- dps: 573.69058
- tps: 428.28279
+ dps: 573.51246
+ tps: 428.17184
  }
 }
 dps_results: {
@@ -267,22 +267,22 @@ dps_results: {
 dps_results: {
  key: "TestMM-Phase2-Lvl40-Settings-Dwarf-p2_ranged_mm-Basic-p2_ranged_mm-NoBuffs-P2-Consumes-LongMultiTarget"
  value: {
- dps: 366.7502
- tps: 478.21176
+ dps: 366.97668
+ tps: 478.2699
  }
 }
 dps_results: {
  key: "TestMM-Phase2-Lvl40-Settings-Dwarf-p2_ranged_mm-Basic-p2_ranged_mm-NoBuffs-P2-Consumes-LongSingleTarget"
  value: {
- dps: 316.06017
- tps: 247.4383
+ dps: 317.37225
+ tps: 249.01728
  }
 }
 dps_results: {
  key: "TestMM-Phase2-Lvl40-Settings-Dwarf-p2_ranged_mm-Basic-p2_ranged_mm-NoBuffs-P2-Consumes-ShortSingleTarget"
  value: {
- dps: 334.82355
- tps: 263.22784
+ dps: 336.05986
+ tps: 265.04535
  }
 }
 dps_results: {

diff --git a/sim/hunter/serpent_sting.go b/sim/hunter/serpent_sting.go
@@ -80,6 +80,7 @@ func (hunter *Hunter) chimeraShotSerpentStingSpell(rank int) *core.Spell {
  return hunter.RegisterSpell(core.SpellConfig{
  ActionID: core.ActionID{SpellID: 409493},
  SpellSchool: core.SpellSchoolNature,
+ CastType: proto.CastType_CastTypeRanged,
  DefenseType: core.DefenseTypeRanged,
  ProcMask: core.ProcMaskEmpty,
  Flags: core.SpellFlagMeleeMetrics | core.SpellFlagPassiveSpell,