Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix seals and procs #1078

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix seals and procs #1078

merged 1 commit into from
Sep 23, 2024

Conversation

Adamrch
Copy link
Contributor

@Adamrch Adamrch commented Sep 21, 2024

No description provided.

@Adamrch Adamrch force-pushed the fixProcsAndSeals branch 5 times, most recently from a9e2485 to 561622b Compare September 22, 2024 08:04
kayla-glick
kayla-glick reviewed Sep 22, 2024
View reviewed changes
sim/core/consumes.go Outdated Show resolved Hide resolved
@Adamrch Adamrch force-pushed the fixProcsAndSeals branch 2 times, most recently from 909ff64 to 9c3946e Compare September 22, 2024 23:10
@Adamrch
fix seals and procs
c05ff87 
fix dismantle proc check and windfury weapon

add comments for proc masks

fix dismantle

rerun results

warrior result reset

add results

fix wf weapon phantom procs and enable stopattack on wf totem
@kayla-glick kayla-glick merged commit 94792a1 into wowsims:master Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayla-glick kayla-glick kayla-glick left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Adamrch @kayla-glick