Rework WS and WF #1097
Closed
Rework WS and WF #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework WS to work like https://github.com/magey/classic-warrior/wiki/Windfury-Totem#triggered-by-melee-spell
Autos have a cast batch where damage and result are calculated, and a damage batch where autos are applied.
This should allow two Instant stike GCD's in a row to proc WS with the second ability benefiting from the AP of the first proc.
(Same for autos but harder to time / align)
Refactored WS/ WF totem to share the same helper function code.
Still need to prevent WS/WF AP from turning off in the middle of a batch though.