[UI] Migrate builds to preset configurations #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
1337LutZ
commented
Sep 26, 2024
•
1337LutZ
commented
- Migrated the Preset Configurations feature from Cata in favor of Preset builds. These presets will be shown on each tab that affects the preset.
- Things you can adjust in a configuration preset:
- Gear
- Talents
- Rotation
- EP Weights (new)
- Encounter (new)
- Encounter (boss/targets)
- Healing Model
- Tanks
- Buffs
- Debuffs
- Raid buffs
- Consumes
- Added option to show a toast warning if a user changes a setting but incompatible data is detected. Example can be found here: https://github.com/wowsims/cata/blob/master/ui/warrior/fury/presets.ts#L21
1337LutZ
commented
Sep 26, 2024
| /////////////////////////////////////////////////////////////////////////// | ||
| // Encounters | ||
| /////////////////////////////////////////////////////////////////////////// | ||
| export const PresetBuildEncounterDefault = PresetUtils.makePresetBuild('Default', { |
There was a problem hiding this comment.
@sanguinerarogue I added these as an example, please feel free to modify these in this branch!
kayla-glick
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.