Prot Paladin: Shield of Righteousness scaling values #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the calculation of Shield of Righteousness damage for accurate scaling based on in-game testing and retrieving unmitigated damage values from logs. Explanation (for posterity) given below.
The tooltip for Shield of Righteousness reads:
Where the flat damage is calculated from the base ability formula (given on wowhead and currently implemented).
The amount of damage contributed by block value has a hidden multiplier and there's an additional 20 base damage not stated by the tooltip. I tested the scaling by having someone run logs during duels while hitting them with different amounts of BV.
https://vanilla.warcraftlogs.com/reports/BkR1r4dq8znX2jDL
Linear regression on these values gives a very clean fit with slope 2.20 and intercept 234. This means that the actual damage calculation for Shield of Righteousness is: