Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warlock and druid reset fixes #938

Merged
merged 5 commits into from
Jul 27, 2024
Merged

Warlock and druid reset fixes #938

merged 5 commits into from
Jul 27, 2024

Conversation

FelixPflaum
Copy link
Contributor

@FelixPflaum FelixPflaum commented Jul 27, 2024 •
edited
Loading

Fixes warlock and druid sim reset errors for #918

  • Make warlock.ActiveCurseAura reset to nil on sim reset.
  • Set default duration of Mark of Chaos auras to 1s (arbitrary value, just can't be NeverExpires) and only alter the duration on curse application if it wasn't made permanent.
  • Make Idol of the Swarm only change Insect Swarm hit debuff duration if it's not a permanent raid debuff.
  • Only deactivate Insect Swarm hit debuff on Insect Swarm DoT expiration if it's not a permanent raid debuff.

@FelixPflaum FelixPflaum changed the title Warlock reset fixes Warlock and druid reset fixes Jul 27, 2024
@FelixPflaum FelixPflaum mentioned this pull request Jul 27, 2024
Open
@kayla-glick kayla-glick merged commit fa3427d into wowsims:master Jul 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayla-glick kayla-glick kayla-glick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FelixPflaum @kayla-glick