Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable non-mcd fire totems #1650

Merged
merged 2 commits into from
Nov 8, 2022
Merged

re-enable non-mcd fire totems #1650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b170c10
re-enable non-mcd fire totems
lologarithm Nov 8, 2022
7107e54
forgot to commit test changes
lologarithm Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions proto/shaman.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,9 @@ message ShamanTotems {
// If set, any time a 2-minute totem is about to expire, will recall and
// replace all totems.
bool recall_totems = 8;

// If set will use fire totems as an MCD instead of manually controlling when to place them.
bool use_fire_mcd = 9;
}

enum ShamanShield {
Expand Down
1 change: 1 addition & 0 deletions sim/shaman/elemental/elemental.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ func RegisterElementalShaman() {

func NewElementalShaman(character core.Character, options *proto.Player) *ElementalShaman {
eleShamOptions := options.GetElementalShaman()
eleShamOptions.Rotation.Totems.UseFireMcd = true // Control fire totems as MCD.

selfBuffs := shaman.SelfBuffs{
Bloodlust: eleShamOptions.Options.Bloodlust,
Expand Down
Loading