Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rogue] Build with sinister strike when < 2 daggers are equipped #1904

Merged
merged 1 commit into from
Nov 23, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sim/rogue/TestAssassination.results
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,8 @@ dps_results: {
dps_results: {
key: "TestAssassination-AllItems-TheFistsofFury"
value: {
dps: 6130.58133
tps: 4352.71275
dps: 4959.1329
tps: 3520.98436
}
}
dps_results: {
Expand Down
8 changes: 6 additions & 2 deletions sim/rogue/rotation.go
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,12 @@ func (rogue *Rogue) setPriorityItems(sim *core.Simulation) {
rogue.Builder = rogue.SinisterStrike
rogue.BuilderPoints = 1
if rogue.Talents.Mutilate {
rogue.Builder = rogue.Mutilate
rogue.BuilderPoints = 2
mhDagger := rogue.Equip[proto.ItemSlot_ItemSlotMainHand].WeaponType == proto.WeaponType_WeaponTypeDagger
ohDagger := rogue.Equip[proto.ItemSlot_ItemSlotOffHand].WeaponType == proto.WeaponType_WeaponTypeDagger
if mhDagger && ohDagger {
rogue.Builder = rogue.Mutilate
rogue.BuilderPoints = 2
}
rogue.setupAssassinationRotation(sim)
}
isMultiTarget := sim.GetNumTargets() > 3
Expand Down