Reorganising some code, changed presets #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
enhancedgore
commented
Nov 25, 2022
•
enhancedgore
commented
- Removed raise_dead.go 's ignore haste line, it does nothing.
- Moved frost sub unh preset talent 5/5 KM => 1/3 subversion + 4/5 KM
- Added basic exp + spell hit cap set for frost sub unh (P1 bis)
- Moved and renamed cancelauraBT method to rotation_shared_helper
- Added cancelauraBT to frost sub unh
- Removed commented and not ready EndOfFight Sequence
- Changed default oblidelay from 0 to 1000.0
- Moved old frost sub unh code to separate .txt file named old_frost_sub_unholy_rotation_code.txt
- Moved frost sub unh preset talent 5/5 KM => 1/3 subversion + 4/5 KM - Added basic exp + spell hit cap set for frost sub unh (P1 bis) - Moved and renamed cancelauraBT method to rotation_shared_helper - Added cancelauraBT to frost sub unh - Removed commented and not ready EndOfFight Sequence - Changed default oblidelay from 0 to 1000.0 - Moved old frost sub unh cold to separate .txt file named old_frost_sub_unholy_rotation_code.txt
Accidentally forgot to change the starting RP preset back to 0, this changes it from 40 (from testing) back to 0 as it should be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.