Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End of Fight Logic for Frost Sub Unholy #1965

Merged
merged 8 commits into from
Dec 6, 2022

Conversation

enhancedgore
Copy link
Contributor

End of fight Logic (sub unh only)

  1. New function to check when 2 death runes are up to work with obAt
  2. Full (mostly working) logic for end of fight

frost sub unholy end of fight logic works, unfortunately the structure of sub blood's code makes it very hard to just add in an action to check for end of fight conditions and to initiate it without messing up other parts of the rotation.

1. New function to check when 2 death runes are up to work with obAt
2. Full (mostly working) logic for end of fight
@enhancedgore enhancedgore changed the title Frosstsucks End of Fight Logic for Frost Sub Unholy Nov 28, 2022
@lologarithm lologarithm merged commit 3ca054c into wowsims:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants