Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item swap core #2257

Merged
merged 6 commits into from
Jan 2, 2023
Merged

Item swap core #2257

merged 6 commits into from
Jan 2, 2023

Commits on Dec 29, 2022

  1. Split berserk enchant into MH and OH aura's so they can be turned off… 

    … individually
    @Horatio27
    Horatio27 committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    ba6c1a4 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2023

  1. Added ItemSwap handler, and implemented it into the character, work v… 

    …ery similiar to AutoAttacks
    @Horatio27
    Horatio27 committed Jan 1, 2023
    Configuration menu
    Copy the full SHA
    3910702 View commit details
    Browse the repository at this point in the history

  2. Refactored PPMManager added a Chance() function, also added a panic t… 

    …o unsupported ItemSlots
    @Horatio27
    Horatio27 committed Jan 1, 2023
    Configuration menu
    Copy the full SHA
    4d77754 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2023

  1. Code cleanup and refactoring, ItemSwap now handles 2H and Shields, al… 

    …so Registered most of the major Enchant Effects to use to the OnItemSwap callback
    @Horatio27
    Horatio27 committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    ef45fd3 View commit details
    Browse the repository at this point in the history

  2. addressed some comments left on the PR

    @Horatio27
    Horatio27 committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    55bfe2b View commit details
    Browse the repository at this point in the history

  3. Added a TODO for cleaning up later so we don't forget

    @Horatio27
    Horatio27 committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    6ca11e8 View commit details
    Browse the repository at this point in the history