Some archive work, minor changes #2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ID, and make it always hit via OutcomeApplier [items] shadowmourne now procs chaos bane when reaching the 10th, not the 11th soul fragment; chaos bane is now an AOE [items] searched EJ posts about shadowmourne, bryntroll, and tiny abomination in a jar, but mostly just left comments
…s (1 ppm -> 2 ppm) proc rates to values found in EJ testing Merge branch 'master' into vigo/archive-works # Conflicts: # sim/paladin/retribution/TestRetribution.results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[paladin] sprinkled some comments, changed Hand of Reckoning's spellID, and make it always hit via OutcomeApplier, not by adding 100% hit bonus
[items] Shadowmourne now procs Chaos Bane when reaching the 10th, not the 11th Soul Fragment (like other capacitors); Chaos Bane is now an AOE
[items] updated Shadowmourne's (50% -> 12 ppm ~ 75%) and Bryntroll's (1 ppm -> 2 ppm) proc rates to values found in EJ testing; also updated Bryntroll's proc to no longer crit (both procs might have a fixed but very low crit chance)