PR to compute weighted EP from a mix of DPS/TPS/DTPS #2902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lologarithm
reviewed
Apr 11, 2023
…ple EP columns are visible.
|
@lologarithm imo, this is ready to merge. |
merijn
force-pushed
the
weighted-ep
branch
2 times, most recently
from
95c9515
to
cd14491
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, we assign a ratio to each EP column and update the current EP with a weighted sum of those columns. Needs two things to be ready for the main sim:
The UI looks terrible currently, someone more comfortable with the CSS/front-end stuff can probably make it look better,
should probably default to hiding the number cells and compute button for DPS specs, who will only be interested in DPS EP anyway