Improve crash handler #3047
Merged
Improve crash handler #3047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have gotten a couple of raid sim crash reports recently:
Unfortunately, these error reports are not really actionable. The links (which under the hood are zlib deflated and base64 encoded settings protos) are truncated. Furthermore, the actual error message and the RNG seed are also truncated (because they are appended after the link, which is already too large).
This PR changes the order of the information: print the error and rng first, and then the (possibly truncated) link. If the link has to be truncated, then a new modal is opened to prompt users to append the full link to the issue manually.
The link can be decoded into the settings proto using the CLI (decodelink command).