fix: foldLine escape character logic #2
Conversation
The escape character logic was not working correctly. The logic of how a line is folded with a final escape character was flawed. Using a loop to consume forward slashes would not allow for an escaped forward slash to be folded correctly, it would append an extra character to the line. - Use if statements to check for escape characters. Only one extra character should be appended to the line, and it should be considered escaped. - Add new test cases to test the escape character logic.
| @@ -134,7 +137,7 @@ export function foldLine (str, maxLen = 76) { | |||
| if ((match = /.*\s+/.exec(curLine)) && /\S/.test(match[0])) { | |||
| // use everything before and including the last white space character (if anything) | |||
| curLine = match[0]; | |||
| } else if ((match = /.*[\x21-\x2f0-9\x5b-\x60\x7b-\x7e]+/.exec(curLine)) && /[^\x21-\x2f0-9\x5b-\x60\x7b-\x7e]/.test(match[0])) { | |||
| } else if (!escaped && (match = /.*[\x21-\x2f0-9\x5b-\x60\x7b-\x7e]+/.exec(curLine)) && /[^\x21-\x2f0-9\x5b-\x60\x7b-\x7e]/.test(match[0])) { | |||
There was a problem hiding this comment.
I don't know if this is the right thing to do, but this was matching the backslash and I don't know why. We need more information about what this condition should be checking for, and figure why its matching a backslash character.
There was a problem hiding this comment.
I don't know why this should match.
'a\\b'.length;
// => 3
match = /.*[\x21-\x2f0-9\x5b-\x60\x7b-\x7e]+/.exec('a\\b');
match[0];
// => 'a\\'Examination of the escapes as Buffers.
Buffer.from('\\');
// <Buffer 5c>
Buffer.from('\x21-');
// <Buffer 21 2d>
Buffer.from('\x2f0');
// <Buffer 2f 30>
Buffer.from('\x5b-');
// <Buffer 5b 2d>
Buffer.from('\x60');
// <Buffer 60>
Buffer.from('\x7b-');
// <Buffer 7b 2d>
Buffer.from('\x7e');
// <Buffer 7e>
There was a problem hiding this comment.
yes I agree also because it is not clear what this code is for, I think in order not to break the lines maybe if there is a consecutive \ and \n immediately after it?
/.*[\x21-\x2f0-9\x5b-\x60\x7b-\x7e]+/.exec('a\\b')
match because
/.*
because this match the 'a'
[\x21-\x2f0-9\x5b-\x60\x7b-\x7e]+
and this the \ and the + matches the previous token between one and unlimited times
The escape character logic was not working correctly.
The logic of how a line is folded with a final escape character was flawed. Using a loop to consume back slashes would not allow for an escaped back slash to be folded correctly, it would append an extra character to the line.