Skip to content

Give a warning when flushing cache on multisite with --url=<url> #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 6, 2023
Merged

Give a warning when flushing cache on multisite with --url=<url> #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44a3f2d
When flushing cache on a multisite give a warning.
janw-me Apr 5, 2023
ca47a55
Updated the --url warning.
janw-me Apr 5, 2023
d6f3fd7
Remove comma from the message
danielbachhuber Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions features/cache.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,3 +132,18 @@ Feature: Managed the WordPress object cache
"""
Error: Could not replace object 'bar' in group 'foo'. Does it not exist?
"""

Scenario: Flushing cache on a multisite installation
Given a WP multisite installation

When I try `wp cache flush`
Then STDERR should not contain:
"""
Warning: Ignoring the --url=<url> argument because flushing the cache affects all sites on a multisite installation.
"""

When I try `wp cache flush --url=example.com`
Then STDERR should contain:
"""
Warning: Ignoring the --url=<url> argument because flushing the cache affects all sites on a multisite installation.
"""
6 changes: 5 additions & 1 deletion src/Cache_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,12 @@ public function delete( $args, $assoc_args ) {
* Success: The cache was flushed.
*/
public function flush( $args, $assoc_args ) {
$value = wp_cache_flush();

if ( WP_CLI::has_config( 'url' ) && ! empty( WP_CLI::get_config()['url'] ) && is_multisite() ) {
WP_CLI::warning( 'Ignoring the --url=<url> argument because flushing the cache affects all sites on a multisite installation.' );
}

$value = wp_cache_flush();
if ( false === $value ) {
WP_CLI::error( 'The object cache could not be flushed.' );
}
Expand Down