Skip to content

Update warning text during multisite cache flushes #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Update warning text during multisite cache flushes #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions features/cache.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,13 +192,13 @@ Feature: Managed the WordPress object cache
When I try `wp cache flush`
Then STDERR should not contain:
"""
Warning: Ignoring the --url=<url> argument because flushing the cache affects all sites on a multisite installation.
Warning: Flushing the cache may affect all sites in a multisite installation, depending on the implementation of the object cache.
"""

When I try `wp cache flush --url=example.com`
Then STDERR should contain:
"""
Warning: Ignoring the --url=<url> argument because flushing the cache affects all sites on a multisite installation.
Warning: Flushing the cache may affect all sites in a multisite installation, depending on the implementation of the object cache.
"""

@require-wp-6.1
Expand Down
2 changes: 1 addition & 1 deletion src/Cache_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ public function delete( $args, $assoc_args ) {
public function flush( $args, $assoc_args ) {

if ( WP_CLI::has_config( 'url' ) && ! empty( WP_CLI::get_config()['url'] ) && is_multisite() ) {
WP_CLI::warning( 'Ignoring the --url=<url> argument because flushing the cache affects all sites on a multisite installation.' );
WP_CLI::warning( 'Flushing the cache may affect all sites in a multisite installation, depending on the implementation of the object cache.' );
}

$value = wp_cache_flush();
Expand Down