For PHP 7.1 compat use get_wp_details() instead of "version.php" include. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #12
Use
Core_Command::get_wp_details()instead of including "wp-include/version.php" to set from/to versions, for PHP 7.1 compatibility, and use WP >= 3.9 for tests (except for one) for PHP >= 7 compatibility.Also as mentioned in #8 (comment), update an old "4.0.16" version missed in #7 and remove the "require-wp-4.0" tag which was masking it from travis.
Also make sure cache is empty for "Verify release hash when downloading new version" test (probably only a run-locally issue).
Also address #10, misleading test prompt order, as it's trivial to fix.