Giving multiple same arguments to mysqldump (via wp db export) only forwards the latest

[astappiev]

Bug Report

• Yes, I reviewed the contribution guidelines.
• Yes, more specifically, I reviewed the guidelines on how to write clear bug reports.

Using the following example:

wp db export --ignore-table-data=database.wp_fc_campaign_emails --ignore-table-data=database.wp_fsmpt_email_logs --ignore-table-data=database.wp_fc_campaign_url_metrics export.sql

Only the value of --ignore-table-data=database.wp_fc_campaign_url_metrics is forwarded to mysqldump.

From the docs:

To specify more than one table to ignore, use the directive multiple times, once for each table. Each table must be specified with both database and table names. See also --no-data.

I expect the arguments are parsed, and duplicate keys are just overridden by each other, which is not expected in this scenario.

[mrsdizzie]

Yes, this is a limitation of using an associative array for arguments. We already have the --exclude_tables option for the same reason:

db-command/src/DB_Command.php

Lines 701 to 710 in c821b92

	$exclude_tables = Utils\get_flag_value( $assoc_args, 'exclude_tables' );
	if ( isset( $exclude_tables ) ) {
	$tables = explode( ',', trim( $assoc_args['exclude_tables'], ',' ) );
	unset( $assoc_args['exclude_tables'] );
	foreach ( $tables as $table ) {
	$command .= ' --ignore-table';
	$command .= ' %s';
	$command_esc_args[] = trim( DB_NAME . '.' . $table );
	}
	}

So I suppose a similar --exclude_tables_data would be needed to support that using the current framework.