Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error only spotlight option #172

Closed
joeldcanfield opened this issue Dec 16, 2022 · 8 comments · Fixed by #188
Closed

error only spotlight option #172

joeldcanfield opened this issue Dec 16, 2022 · 8 comments · Fixed by #188

Comments

@joeldcanfield
Copy link
Contributor

Would like an option to spotlight only errors, and not include warnings.

For myself, warnings are essentially meaningless. "Almost broken" doesn't warrant my attention.

@schlessera
Copy link
Member

"Almost broken" doesn't warrant my attention.
😆

Yes, It makes sense to add a --spotlight flag. Are you open to providing a PR for this?

@joeldcanfield
Copy link
Contributor Author

Beyond my ability. Wish I could; we're operating just outside my wheelhouse here and I'd love to expand said wheelhouse. (Brain issues slowing me down, hopefully temporarily.)

@joeldcanfield
Copy link
Contributor Author

Arg. Please ignore that. I will return and reply more clearly and possibly even correctly.

@joeldcanfield
Copy link
Contributor Author

I won't be able to make this happen (health issues.)

@ernilambar
Copy link
Member

Looks like we already have --spotlight argument which displays error and warning.
Ref: #38

Is this enough or should we introduce new flag for error only?

@joeldcanfield
Copy link
Contributor Author

for my purposes an error-only flag would be helfpul; I'd like to prevent scraping and scrapping pointless warnings in my results. as mentioned above, "almost broken" has no value in my use of the tool, only "all the way broken".

@ernilambar
Copy link
Member

Rather than adding new flag for showing errors only, I have added argument to filter by status, like --status=error or --status=warning. This approach is what we have used in several WP CLI commands.
PR - #188

@joeldcanfield
Copy link
Contributor Author

matching existing code is perfect. excellent. thanks very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants