Add option to filter check results #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekn
approved these changes
May 30, 2024
There was a problem hiding this comment.
The code change looks clear and new feature works as expected. I ran behat tests:
% WP_CLI_TEST_DBHOST=127.0.0.1:3306 composer behat -- features/check.feature
> run-behat-tests 'features/check.feature'
..............................................
6 scenarios (6 passed)
46 steps (46 passed)
0m25.01s (10.86Mb)
Side note - I needed to copy behat.yml from another command repository to run tests for this command. Should we add it here, too?
See #190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #172