block.json string extraction

[swissspidy]

Fixes #163.

Todo:

• make tests pass

[gziolo]

Thank you for working on it, it looks close to ready. I left some comments so we could decide whether we need to refine the original plan :)

[gziolo]

Thanks for working on it @swissspidy. How can I help to make the tests pass? :)

[swissspidy]

@gziolo I first need to get the tests setup properly running again on my machine, then I can debug them.

[swissspidy]

@gziolo Tests are passing now, so this should be ready soon 🙂 But I also just learned about WordPress/gutenberg#21490...

[gziolo]

@gziolo Tests are passing now, so this should be ready soon 🙂 But I also just learned about WordPress/gutenberg#21490...

Oh, interesting. It looks like more use cases pop up 😄 I don't think theme.json is stable enough to wait for it.

For this PR ✅ 🚢

[gziolo]

There is now REST API endpoint for block types merged in the Gutenberg repository. It should become a part of WordPress core as part of WordPress 5.5 release. Related PR:
WordPress/gutenberg#21065

I'm not an expert, but it looks like OPTIONS returns JSON schema for the shape that this endpoint returns. Would it be possible to extend it to include information on which fields are translatable?

Edit: The schema that REST API uses follows snake_case for field names, while the block.json file uses camelCase, so this might require an intermediate step to make it all work.

[swissspidy]

This kind of schema would need to live somewhere outside of WordPress context, where WP-CLI and other tools can easily assess which fields in block.json are translatable and which aren't.

---

In any case, I feel like this discussion should be better held in some Gutenberg GH issue or something, and shouldn't necessarily block this PR.

[gziolo]

I landed changes in WordPress core WordPress/wordpress-develop@822ca9e that makes the changes I mentioned lately:

• styles
• textdomain

There is a corresponding PR that aligns Gutenberg code and updates RFC for block registration: WordPress/gutenberg#22695.

[swissspidy]

@gziolo Awesome! Updated the code here accordingly.

[gziolo]

Thanks for applying changes so quickly, everything is aligned now 🎉

[gziolo]

This kind of schema would need to live somewhere outside of WordPress context, where WP-CLI and other tools can easily assess which fields in block.json are translatable and which aren't.

It looks like JSON schema is in works for the purpose of validation in Block Directory:
https://github.com/tellyworth/plugin-directory/pull/2/files#diff-73a27cb25a34ab6bcbb40bbbc9c436afR35

Where would be the best place to keep the common schema? I guess that Block Directory sooner or later would need to add its own flavors :)

[swissspidy]

Probably on WordPress.org somewhere

[gziolo]

This kind of schema would need to live somewhere outside of WordPress context, where WP-CLI and other tools can easily assess which fields in block.json are translatable and which aren't.

I opened a ticket in WordPress track to continue the discussion: https://core.trac.wordpress.org/ticket/50615.