-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CS checking based on the WP_CLI_CS
ruleset
#108
Conversation
Update .distignore and .gitignore with phpcs/phpunit config files Update wp-cli-tests to 2.1
…fixedClassFound sniff and some files Add CS fixes in src/Package_Command.php tests/test-composer-json.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thrijith Thanks for fixing up yet another one! I've left some comments in-line.
@@ -598,8 +609,8 @@ private function get_composer() { | |||
// Best to just pretend we're installing a package from ~/.wp-cli or similar | |||
chdir( pathinfo( $composer_path, PATHINFO_DIRNAME ) ); | |||
|
|||
// Prevent DateTime error/warning when no timezone set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops... sorry, I didn't mean to suggest that this line should be removed.
6bed192
to
18f5bd4
Compare
Implement CS checking based on the `WP_CLI_CS` ruleset
Add a PHPCS ruleset using the new
WP_CLI_CS
standard.Fixes #106
Related wp-cli/wp-cli#5179