Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CS checking based on the WP_CLI_CS ruleset #108

Merged
merged 3 commits into from
Apr 24, 2019

Conversation

thrijith
Copy link
Member

Add a PHPCS ruleset using the new WP_CLI_CS standard.

Fixes #106

Related wp-cli/wp-cli#5179

Update .distignore and .gitignore with phpcs/phpunit config files
Update wp-cli-tests to 2.1
…fixedClassFound sniff and some files

Add CS fixes in src/Package_Command.php tests/test-composer-json.php
@thrijith thrijith requested a review from a team as a code owner April 23, 2019 07:09
Copy link

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thrijith Thanks for fixing up yet another one! I've left some comments in-line.

@@ -598,8 +609,8 @@ private function get_composer() {
// Best to just pretend we're installing a package from ~/.wp-cli or similar
chdir( pathinfo( $composer_path, PATHINFO_DIRNAME ) );

// Prevent DateTime error/warning when no timezone set
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops... sorry, I didn't mean to suggest that this line should be removed.

@thrijith thrijith force-pushed the feature/use-phpcs branch from 6bed192 to 18f5bd4 Compare April 23, 2019 16:07
@schlessera schlessera added this to the 2.0.4 milestone Apr 24, 2019
@schlessera schlessera merged commit 52fea16 into master Apr 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/use-phpcs branch April 24, 2019 09:34
@schlessera schlessera modified the milestones: 2.0.4, 2.0.5 Apr 24, 2019
schlessera added a commit that referenced this pull request Jan 5, 2022
Implement CS checking based on the `WP_CLI_CS` ruleset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt and enforce new WP_CLI_CS standard
3 participants