Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GitLab.com URLs #117

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Conversation

drzraf
Copy link
Contributor

@drzraf drzraf commented Mar 26, 2020

fixes #110

@drzraf drzraf requested a review from a team as a code owner March 26, 2020 03:10
@drzraf drzraf force-pushed the feature/gitlab-support branch from 5ceaebd to 2882090 Compare March 26, 2020 03:11
@schlessera
Copy link
Member

@drzraf The reason for why this build failed tests was fixed in the framework. Can you merge latest master into this PR? It should fix the tests then.

@drzraf drzraf force-pushed the feature/gitlab-support branch from 2882090 to ec1ea75 Compare April 8, 2020 23:30
@drzraf
Copy link
Contributor Author

drzraf commented Apr 29, 2020

friendly ping

@schlessera schlessera added this to the 2.0.7 milestone Jun 4, 2020
@schlessera schlessera merged commit 3b7eb34 into wp-cli:master Jun 4, 2020
@schlessera schlessera changed the title support GitLab.com URL (#110) Support GitLab.com URLs Jun 4, 2020
@schlessera
Copy link
Member

Thanks for the PR, @drzraf !

@drzraf
Copy link
Contributor Author

drzraf commented Mar 2, 2021

I wonder. PR reached 2.0.7 which was released after the latest stable release of wp-cli.
I tried to override Phar built-in's package command (wp package install wp-cli/package-command:2.0.9), but I'm said that package-command requires wp-cli/wp-cli ~2.5. (I'm on 2.4.0)

Does it mean I've no way to benefit from the PR, even though a package-command release happened until a new release of wp-cli itself is done? (It's annoying because I'd like to avoid using a non-stable release of wp-cli for this particular usage and only use an updated version of the package-commad).

@schlessera
Copy link
Member

@drzraf I just now noticed this comment, unfortunately.

Normally I don't add such strict requirements to the packages. This was made necessary because there was so much breakage and compact issues from v2.4.0 to v2.5.0. You could always try to use a custom alias in your $HOME/.wp-cli/packages/composer.json file. Or, what's easier, is to switch to latest WP-CLI --nightly release instead, which works for fulfilling the ^2.5.0 requirements. Nightly would not normally make sense for production use, but given that PHP 8 and WP pretty flat-out broke v2.4.0, v2.5.0 is actually the much more stable one.

However, all of this is probably to late for you now anyway, as I'm about to push release v2.5.0 out in an hour or so, which means v2.5.0 will be the latest stable.

schlessera added a commit that referenced this pull request Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check_git_package_name hardcode reference to GitHub
3 participants