Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assume default package name if composer.json file cannot be retrieved #78

Merged
merged 4 commits into from
Apr 19, 2018
Merged

Assume default package name if composer.json file cannot be retrieved #78

merged 4 commits into from
Apr 19, 2018

Conversation

phlbnks
Copy link

@phlbnks phlbnks commented Apr 13, 2018

  • Warning, not Error, when composer.json cannot be retrieved
  • Return best-guess $package_name

Handle unavailable composer.json on private repo
753b64c 
- Warning not Error when composer.json cannot be retreived
- Return best-guess $package_name
@phlbnks phlbnks mentioned this pull request Apr 13, 2018
Closed
@phlbnks
Copy link
Author

phlbnks commented Apr 13, 2018

Realised I've broken other tests. Fixing.

Phil Banks added 2 commits April 13, 2018 14:30
@phlbnks
Copy link
Author

phlbnks commented Apr 13, 2018

Previous test failed due to OOM error, but I realised that array dereferencing isn't supported in 5.3 anyway so I've updated to remove that.

@phlbnks
Copy link
Author

phlbnks commented Apr 13, 2018

OOM again ¯_(ツ)_/¯

@schlessera
Copy link
Member

@emirpprime The OOM should now be fixed if you merge latest master.

@schlessera schlessera added this to the 1.0.13 milestone Apr 14, 2018
@danielbachhuber
Copy link
Member

I've merged master.

@schlessera schlessera merged commit 63bfef0 into wp-cli:master Apr 19, 2018
@schlessera
Copy link
Member

Thanks for the pull request, @emirpprime !

@schlessera schlessera changed the title Handle unavailable composer.json on private repo (issue #76) Assume default package name if composer.json file cannot be retrieved Apr 19, 2018
schlessera added a commit that referenced this pull request Jan 5, 2022
@schlessera
Merge pull request #78 from emirpprime/master
4e9003a 
Handle unavailable composer.json on private repo

Fixes #76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees
No one assigned
Labels
bug command:package-install
Projects
None yet
Milestone
1.0.13
Development

Successfully merging this pull request may close these issues.
3 participants
@phlbnks @schlessera @danielbachhuber