Adds optional type argument accepted by str_pad()

[urlund]

Issue #121

[schlessera]

@urlund Before submitting a pull request, could you create an issue first describing the problem you're trying to solve?

See the Handbook section about pull requests for more details about our processes.

[urlund]

@schlessera Done :)

[gitlost]

Thanks for the PR @urlund.

I think it would be better (simpler at least) to only support $pad_type, as $pad_string requires allowing for varying length strings, and I don't see much application for it anyway.

Also could you add phpunit tests please? (See https://github.com/wp-cli/php-cli-tools/blob/master/tests/test-cli.php#L41).

(Just to note: #122 will have to be merged once it's approved for the tests to pass on Travis.)

[urlund]

Done?

[gitlost]

Thanks @urlund, just some extra tests and it's good to go.

[gitlost]

That's cool. Could you also add some tests to exercise the new functionality, eg

$this->assertSame( 5, strpos( \cli\Colors::pad( 'hello', 7, false, false, STR_PAD_RIGHT ), ' ' ) );
$this->assertSame( 6, strrpos( \cli\Colors::pad( 'hello', 7, false, false, STR_PAD_RIGHT ), ' ' ) );
$this->assertSame( 0, strpos( \cli\Colors::pad( 'hello', 7, false, false, STR_PAD_LEFT ), ' ' ) );
$this->assertSame( 1, strrpos( \cli\Colors::pad( 'hello', 7, false, false, STR_PAD_LEFT ), ' ' ) );
$this->assertSame( 0, strpos( \cli\Colors::pad( 'hello', 7, false, false, STR_PAD_BOTH ), ' ' ) );
$this->assertSame( 6, strrpos( \cli\Colors::pad( 'hello', 7, false, false, STR_PAD_BOTH ), ' ' ) );
$this->assertSame( \cli\Colors::pad( 'hello', 7 ), \cli\Colors::pad( 'hello', 7, false, false, STR_PAD_RIGHT ) );

[urlund]

@gitlost better? ;)

[gitlost]

@urlund Oh yes!

[danielbachhuber]

Tagged v0.11.7: https://github.com/wp-cli/php-cli-tools/releases/tag/v0.11.7