Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up a couple of PHPCS issues #50

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Clean up a couple of PHPCS issues #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c952c60
Remove unused argument
danielbachhuber Sep 1, 2023
58614a7
Ignore unused `$assoc_args` argument
danielbachhuber Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .maintenance/src/GitHub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,14 +283,12 @@ public static function delete_label(
*
* @param string $project
* @param integer $milestone_id
* @param bool $only_merged
*
* @return array
*/
public static function get_project_milestone_pull_requests(
$project,
$milestone_id,
$only_merged = true
$milestone_id
) {
$request_url = sprintf(
self::API_ROOT . 'repos/%s/issues',
Expand Down
2 changes: 1 addition & 1 deletion .maintenance/src/Milestones_After_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ final class Milestones_After_Command {
*
* @when before_wp_load
*/
public function __invoke( $args, $assoc_args ) {
public function __invoke( $args, $assoc_args ) { // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter.FoundAfterLastUsed

list( $repo, $milestone_name ) = $args;

Expand Down
2 changes: 1 addition & 1 deletion .maintenance/src/Milestones_Since_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ final class Milestones_Since_Command {
*
* @when before_wp_load
*/
public function __invoke( $args, $assoc_args ) {
public function __invoke( $args, $assoc_args ) { // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter.FoundAfterLastUsed

list( $repo, $date ) = $args;

Expand Down
2 changes: 1 addition & 1 deletion .maintenance/src/Release_Date_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ final class Release_Date_Command {
*
* @when before_wp_load
*/
public function __invoke( $args, $assoc_args ) {
public function __invoke( $args, $assoc_args ) { // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter.FoundAfterLastUsed

list( $repo, $milestone_name ) = $args;

Expand Down