Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump phpcompatibility requirement to development branch #218

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

mrsdizzie
Copy link
Member

As noted in #217 there hasn't been a release of phpcompatibility since 2019 and the current version can't detect PHP 8 specific code. It probably has other useful fixes for earlier versions of PHP that have been applied in the last several years as well.

Fixes #217

As noted in wp-cli#217 there hasn't been a release of phpcompatibility since
2019 and the current version can't detect PHP 8 specific code. It
probably has other useful fixes for earlier versions of PHP that have
been applied in the last several years as well.

Fixes wp-cli#217
@mrsdizzie mrsdizzie requested a review from a team as a code owner August 17, 2024 15:32
@mrsdizzie mrsdizzie added bug Something isn't working scope:testing labels Aug 17, 2024
@mrsdizzie mrsdizzie added this to the 4.3.2 milestone Aug 17, 2024
Copy link
Member

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let‘s see how it goes

@swissspidy swissspidy merged commit c6d1a2c into wp-cli:main Aug 17, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working scope:testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

php-compatibility for phpcs is out of date
2 participants