Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Replace mysql_native_password with caching_sha2_password #220

Merged

Conversation

aaln
Copy link
Contributor

@aaln aaln commented Sep 17, 2024

Bug Ticket: wp-cli/ideas#194

This PR should fix the composer prepare-tests command issue on the wp-cli-dev repo existing for anyone running sql version 8.0.4+

@ohryan
Copy link

ohryan commented Sep 17, 2024

While this PR resolves the issue on a fresh install, if mysql has an existing TEST_USER with mysql_native_password set as its auth plugin behat will fail after and upgrade to mysql 9.0.

I believe we could potentially detect this by querying for the user.
However I'm not sure if:

  1. That's in scope of this PR.
  2. It's truely neccessary, since updating users with mysql_native_password would should be part of the mysql 9.0 upgrade process.

@swissspidy
Copy link
Member

Let's try this and then we can follow-up with a new PR if needed 👍

@swissspidy swissspidy changed the title Replace sql v8.0.4+ unsupported mysql_native_password plugin with suppored caching_sha2_password plugin Tests: Replace mysql_native_password with caching_sha2_password Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants