Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra arguments to PHPUnit 10+ #222

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

swissspidy
Copy link
Member

Display warnings/notices/deprecations on PHPUnit 10+ and fail on them as well.

@swissspidy swissspidy added this to the 4.3.2 milestone Oct 1, 2024
@swissspidy swissspidy requested a review from a team as a code owner October 1, 2024 11:55
Copy link
Contributor

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for setting this up @swissspidy!

CLI flags are the ones we discussed and the ones I believe should be added to allow PHPUnit 10+ to also flag PHP deprecations/notices/warnings.

Tested on Windows and found working ✅

@swissspidy swissspidy merged commit 1c73dfa into main Oct 1, 2024
40 of 42 checks passed
@swissspidy swissspidy deleted the update-phpunit-bash-script branch October 1, 2024 12:41
@swissspidy swissspidy modified the milestones: 4.3.2, 4.3.3 Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants