Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error if a custom Auth Secret has not been set #87

Open
jasonbahl opened this issue Apr 1, 2020 · 1 comment
Open

Throw an error if a custom Auth Secret has not been set #87

jasonbahl opened this issue Apr 1, 2020 · 1 comment
Labels
effort: low impact: high unblocks new usecases, substantial improvement to existing feature, fixes a major bug

Comments

@jasonbahl
Copy link
Collaborator

Leaving the default Auth Secret makes it easy for Auth Tokens to be forged and attackers to gain access to a site.

This plugin should throw an Exception if the Auth Secret has not been set via filter or the constant.
@jasonbahl jasonbahl added effort: low impact: high unblocks new usecases, substantial improvement to existing feature, fixes a major bug labels Apr 1, 2020
jasonbahl added a commit to jasonbahl/wp-graphql-jwt-authentication that referenced this issue Apr 1, 2020
@jasonbahl
wp-graphql#87 - Force Auth Secret to be set, else throw Exception
2528f41
jasonbahl added a commit that referenced this issue Apr 1, 2020
@jasonbahl
Merge pull request #88 from jasonbahl/bug/#87-force-auth-secret-to-be…
d0faaab 
…-set

#87 - Force Auth Secret to be set, else throw Exception
@duffn
Copy link

duffn commented Oct 12, 2020

This looks to be closed in #88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: low impact: high unblocks new usecases, substantial improvement to existing feature, fixes a major bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasonbahl @duffn