Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"DownloadableItem" type and connection added. #219

Conversation

kidunot89
Copy link
Member

@kidunot89 kidunot89 commented Jan 22, 2020

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

  • Adds a new DownloadableItem type
  • The downloadableItems field on the Order type resolves to a DownloadableItem connection.
  • New test added DownloadableItemQueriesTest
  • ConnectionPaginationTest updated.

Example Usage

query {
    customer {
        orders {
            nodes {
                downloadableItems {
                    nodes {
                        url
                        accessExpires
                        downloadId
                        downloadsRemaining
                        name
                        product {
                            productId
                        }
                        download {
                            downloadId
                        }
                    }
                }
            }
        }
    }
}

Does this close any currently open issues?

#218

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

Operating System: Linux Mint 19.2

WordPress Version: 5.3.2

@kidunot89 kidunot89 added enhancement New feature or request new types Feature adds a new type(s) bugfix Implements bugfix new connections Feature add new connections to the schema labels Jan 22, 2020
@kidunot89 kidunot89 added this to the v0.4.0 milestone Jan 22, 2020
@kidunot89 kidunot89 requested a review from jasonbahl January 22, 2020 05:06
@kidunot89 kidunot89 self-assigned this Jan 22, 2020
@kidunot89 kidunot89 mentioned this pull request Jan 22, 2020
4 tasks
@kidunot89 kidunot89 force-pushed the feature/downloadable-items-type-and-connection branch from 2b30494 to b57ec1c Compare January 22, 2020 08:08
@kidunot89 kidunot89 merged commit 98af2b0 into wp-graphql:release/v0.4.0 Jan 22, 2020
@kidunot89 kidunot89 deleted the feature/downloadable-items-type-and-connection branch January 22, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Implements bugfix enhancement New feature or request new connections Feature add new connections to the schema new types Feature adds a new type(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant