Skip to content

Conversation

johnforte
Copy link
Contributor

@johnforte johnforte commented Aug 16, 2021

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

Since the woocommerce session takes into account that a guest user session can generate a token, this should be exposable thru the customer sessionToken trait.

Does this close any currently open issues?

No.

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version: 0.10.3
  • WPGraphQL Version: 1.6.3
  • WordPress Version: 5.8
  • WooCommerce Version: 5.5.2

Copy link
Collaborator

@kidunot89 kidunot89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnforte, I understand what you are trying to solve here, but this would remove all context for this field resulting in admin getting there own JWTs exposed.

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 1b4317b and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 77.0% (0.0% change).

View more on Code Climate.

Copy link
Collaborator

@kidunot89 kidunot89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnforte Perfect. Thanks for the work on this 🙏🏿

@kidunot89 kidunot89 merged commit 2ae2890 into wp-graphql:develop Sep 8, 2021
@kidunot89 kidunot89 added the bugfix Implements bugfix label Sep 8, 2021
@kidunot89 kidunot89 changed the title feature: customer call returns session token for guest users bugfix: customer call returns session token for guest users Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Implements bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants