feat: "product" and "variation" connections added to LineItem type #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidunot89
added
enhancement
kidunot89
force-pushed
the
feat/line-item-product-connections
branch
from
5ac35dd to
0ec6943
Compare
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| $resolver = new PostObjectConnectionResolver( $source, $args, $context, $info, 'product_variation' ); | ||
|
|
||
| if ( ! $id ) { | ||
| return null; |
There was a problem hiding this comment.
Avoid too many return statements within this method.
| return null; | ||
| } | ||
|
|
||
| return $resolver |
There was a problem hiding this comment.
Avoid too many return statements within this method.
| 'toType' => 'Product', | ||
| 'oneToOne' => true, | ||
| 'resolve' => function ( $source, array $args, AppContext $context, $info ) { | ||
| $id = $source->productId; // @phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase |
There was a problem hiding this comment.
Avoid variables with short names like $id. Configured minimum length is 3.
|
Code Climate has analyzed commit 008b9c9 and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 75.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.
🚨Please review the guidelines for contributing to this repository.
What does this implement/fix? Explain your changes.
LineItemfields'productandvariationchanged to connections to be consist with theCartItemtype.Does this close any currently open issues?
Fixes #478
Any relevant logs, error output, GraphiQL screenshots, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Any other comments?
…
Where has this been tested?