Get $order in checkout mutation #605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| throw new UserError( $order_id->get_error_message( 'checkout-error' ) ); | ||
| } | ||
|
|
||
| $order = \WC_Order_Factory::get_order( $order_id ); |
There was a problem hiding this comment.
Avoid using static access to class '\WC_Order_Factory' in method 'mutate_and_get_payload'.
|
Code Climate has analyzed commit b417b92 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 75.0% (0.0% change). View more on Code Climate. |
kidunot89
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Currently
$orderis set asnullat the beginning (line 133), and is never updated. Then it is used in the catch block to attempt a order removal. From my understanding this will never succeed, since$orderis alwaysnull.This gets the order object for use in the catch block, and in the
graphql_woocommerce_before_checkoutaction.So
$orderalso referenced in the doc for actiongraphql_woocommerce_before_checkout, but the ID is passed. I'm not sure if it's best to update the description to$order_id, or change what is passed like I've done here?