Skip to content

Conversation

kidunot89
Copy link
Collaborator

@kidunot89 kidunot89 commented Aug 26, 2022

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

  • Composer autoloader no longer used to load plugin files
  • WPGraphQL v1.9.x connection resolver support added.
  • PHPCS rules updated and compliance met. (Bye bye old style array() and hello short syntax [ ])

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version:
  • WPGraphQL Version:
  • WordPress Version:
  • WooCommerce Version:

@kidunot89 kidunot89 added the bugfix Implements bugfix label Aug 26, 2022
@kidunot89 kidunot89 requested a review from jasonbahl August 26, 2022 18:25
@kidunot89 kidunot89 added this to the v0.11.2 milestone Aug 26, 2022
Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 12649 lines exceeds the maximum allowed for the inline comments feature.

@qlty-cloud-legacy
Copy link

There are too many results to compare

The test coverage on the diff in this pull request is 57.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 76.4% (-1.3% change).

View more on Code Climate.

@kidunot89 kidunot89 merged commit 9073793 into wp-graphql:develop Aug 26, 2022
@kidunot89 kidunot89 deleted the chore/autoload-removed branch August 26, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Implements bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant