fix: product variation raw price not visible for public users #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome work! Thanks a lot! |
kidunot89
force-pushed
the
fix/variations-price-public-users-andres
branch
from
a7698f4 to
c26ecf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨Please review the guidelines for contributing to this repository.
What does this implement/fix? Explain your changes.
The raw product price variation comes as null while querying them as a public user (not authenticated).
There is a capability check that was added on #213 while addressing sensitive data being exposed to not authenticated users. Nevertheless, the raw prices for variation shouldn't have been included.
The raw prices for other product object types (Simple product, Variable product, etc.) work fine without being authenticated. Not sure why this behaviour is applied only for the variation prices: https://github.com/wp-graphql/wp-graphql-woocommerce/blob/develop/includes/model/class-product.php#L361
For sake of persistency, it should be added to the other object types or removed from the variation.
Does this close any currently open issues?
Product variation raw prices not visible for public users (not authenticated)
Where has this been tested?
**WooGraphQL Version: 0.11.2
**WPGraphQL Version: 1.12.2
**WordPress Version: 6.11
**WooCommerce Version: 7.1.0