Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ProductWithAttributes and ProductVariation interfaces added #803

Merged
merged 2 commits into from
Sep 16, 2023

Conversation

kidunot89
Copy link
Member

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

  • Two more interfaces added.
    • ProductWithAttributes
    • ProductVariation
  • The ProductVariation object type has been replace with the SimpleProductVariation type.
  • The other interfaces were renamed.
    • InventoriedProducts to InventoriedProduct
    • DownloadableProducts to DownloadableProduct
    • ProductsWithPricing to ProductWithPricing
    • ProductsWithDimensions to ProductWithDimensions
    • ProductsWithVariations to ProductWithVariations

Example

query {
  products(first: 100) {
    nodes {
      ... on ProductWithAttributes {
        defaultAttributes {
          nodes {
            label
            value
          }
        }
      }
      ... on ProductWithVariations {
        variations(first: 50) {
          nodes {
            name
            attributes {
              nodes {
                label
                value
              }
            }
          }
        }
      }
    }
  }
}

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version:
  • WPGraphQL Version:
  • WordPress Version:
  • WooCommerce Version:

@kidunot89 kidunot89 merged commit c526a5b into wp-graphql:develop Sep 16, 2023
@kidunot89 kidunot89 deleted the feat/more-product-interfaces branch September 16, 2023 01:04
@kidunot89 kidunot89 added enhancement New feature or request breaking change Solution will break some older solutions new types Feature adds a new type(s) labels Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Solution will break some older solutions enhancement New feature or request new types Feature adds a new type(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant